Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3441): fix typings for createIndexes #2915

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix(NODE-3441): fix typings for createIndexes #2915

merged 2 commits into from
Jul 21, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jul 20, 2021 •
edited
Loading

This isn't super clear from the index management specification, but it seems like IndexDescription needs to extend CreateIndexesOptions, since each index description may also contain options.

@emadum emadum marked this pull request as ready for review July 20, 2021 18:41
emadum
emadum commented Jul 20, 2021
View reviewed changes
test/types/mongodb.test-d.ts Outdated Show resolved Hide resolved
@emadum emadum requested a review from nbbeeken July 20, 2021 23:58
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 21, 2021
@emadum emadum force-pushed the NODE-3441/4.0/fix-createIndexes-typings branch from 56ae872 to c626c94 Compare July 21, 2021 04:24
nbbeeken
nbbeeken approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken requested a review from dariakp July 21, 2021 14:57
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 21, 2021
dariakp
dariakp approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit f87f376 into 4.0 Jul 21, 2021
@nbbeeken nbbeeken deleted the NODE-3441/4.0/fix-createIndexes-typings branch July 21, 2021 16:35
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
fix(NODE-3441): fix typings for createIndexes (#2915)
1dd5255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @nbbeeken @dariakp